Adding stories from markdown for the other modules that didn't have any stories #427
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
broccolini
approved these changes
Jan 13, 2018
This was referenced Mar 21, 2018
This was referenced Dec 13, 2022
This was referenced Dec 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I went through the rest of our modules and added the
storiesFromMarkdownparser to read in all of the code snippets.The approval I'm looking for here is if the titles I picked for the code snippets need any improvements. I followed what the header said and tried to make it consistent with previous story naming.
As a small bonus in this pr, I added the version number of primer to the storybook title, so now it looks like this
[ Primer v10.2.0 ][ ⌘ ]